Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MSVC warnings #1680

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Disable MSVC warnings #1680

merged 1 commit into from
Dec 10, 2024

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Dec 9, 2024

Refs #1513.

Disable MSVC warnings about unknown pragmas and conversions between different types.

While generally we should leave the warnings on but most files have a dozen of warnings and it slowed compilation a lot and hid important messages. Let's just turn them off for now.

@awni awni merged commit 0070e36 into ml-explore:main Dec 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants